(Palmer is a super-smart and nice guy who I have worked with, and IMHO didn't deserve this little rant from Linus, but he made a mistake, owned up to it, and didn't make a fuss.)
I'd generally agree with Linus that these are confusing to use. It's not clear if you would pass (hi, lo) or (lo, hi) without looking at the definition of the macro; all of the other macros in that function are very clear about what they will produce.
It's worth reading Palmer's reply, which is a correct response: https://lore.kernel.org/lkml/mhng-655602B8-F102-4B0F-AF4A-4A...
(Palmer is a super-smart and nice guy who I have worked with, and IMHO didn't deserve this little rant from Linus, but he made a mistake, owned up to it, and didn't make a fuss.)
This is the full patchset: https://git.kernel.org/pub/scm/linux/kernel/git/riscv/linux....
The offending macros are defined in include/linux/wordpart.h: https://git.kernel.org/pub/scm/linux/kernel/git/riscv/linux....
I'd generally agree with Linus that these are confusing to use. It's not clear if you would pass (hi, lo) or (lo, hi) without looking at the definition of the macro; all of the other macros in that function are very clear about what they will produce.